Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sile 0.15.6 #197650

Closed
wants to merge 1 commit into from
Closed

sile 0.15.6 #197650

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added lua Lua use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` icu4c ICU use is a significant feature of the PR or issue labels Nov 14, 2024
@alerque
Copy link
Contributor

alerque commented Nov 14, 2024

This should not be merged as is. A simple bump would work, but it will bring the same problems the existing Homebrew package has. In this release upstream we made some accommodations specifically so brew's somewhat unorthodox pseudo-system vendoring of dependencies will work better and not conflict with end users trying to install 3rd party packages.

Instead this package needs to take advantage of the new configure time option --with-vendored-luarocks-dir=PATH and ditch many of the other obsolete work rounds.

I suggest first merging my existing PR #196600 that covers much of this ground, then I will submit a PR for the 0.15.6 bump that uses the new option for Homebrew's use case.

@daeho-ro daeho-ro added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 14, 2024
@alerque
Copy link
Contributor

alerque commented Nov 15, 2024

I just posted #197800 which should handle this version bump properly; this PR should be closed.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Nov 17, 2024
@SMillerDev SMillerDev closed this Nov 18, 2024
@github-actions github-actions bot deleted the bump-sile-0.15.6 branch November 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` icu4c ICU use is a significant feature of the PR or issue lua Lua use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants